DON-1112: Add user-friendly validation for amount errors on regular g… #1821
+277
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdsl
commented
Jan 10, 2025
| ) { | ||
| this.submitting = false; | ||
| this.stripeError = this.getStripeFriendlyError(error, context); | ||
| this.stripeError = getStripeFriendlyError(error, context); | ||
| this.toast.showError(this.stripeError); | ||
| this.stripeResponseErrorCode = error?.code; | ||
|
|
||
| this.jumpToStep('Payment details'); | ||
| this.goToFirstVisibleError(); | ||
| } | ||
|
|
There was a problem hiding this comment.
function below moved to stripe.service.ts to allow sharing with new component. Not sure if that's the best place to move it to - not sure if its idiomatic or not to put extra stuff in the file alongside the service class in Angular.
bdsl
force-pushed
the
DON-1112-regular-giving-validation
branch
from
984c9ed to
910ce74
Compare
Instead of just displyaing the form as a toast we now add it to the page, and also change the spinner back to a button to allow the donor to stop watching it and perhaps try again.
NoelLH
approved these changes
Jan 10, 2025
|
|
||
| export function getStripeFriendlyError( | ||
| error: StripeError | {message: string, code: string, decline_code?: string, description?: string} | undefined, | ||
| context: 'method_setup'| 'card_change'| 'confirm', |
There was a problem hiding this comment.
Liking this narrower type; assuming rest of this is moved only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iving form